search

nanshe-org / nanshe

An image processing toolkit
https://nanshe-org.github.io/nanshe
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Require NumPy 1.11+ #482

Closed jakirkham closed 5 years ago

jakirkham commented 5 years ago

This is a workaround for a conda-build bug in bdist_conda. ( https://github.com/conda/conda-build/issues/3333 ) However having a constraint for NumPy here is reasonable. Though the code was designed for such an old version of NumPy that most versions likely work without issues. For now we make the requirement 1.11 as we are unlikely to go further back than that.

jakirkham commented 5 years ago

FWIW the fact that the test suite has been running fine even with NumPy 1.11 pinned is a pretty good indicator that 1.11 is at least a safe minimum.