search

nanxiaobei / antd-img-crop

🗡 An image cropper for Ant Design Upload
MIT License
497 stars 156 forks source link

prop-types is a peer dependencies not a dev dependency #165

Closed damiangreen closed 2 years ago

damiangreen commented 2 years ago

This forces yarn 3 users to have to add packageExtensions overrides for this library

nanxiaobei commented 2 years ago

It is peer?

https://github.com/nanxiaobei/antd-img-crop/blob/main/package.json#L32

damiangreen commented 2 years ago

yes

damiangreen commented 2 years ago

I think you may have misunderstood. it is meant to be a dev dependency, currently it is a peer dependency Shall i raise a PR?

nanxiaobei commented 2 years ago

It's in the source code, so it's not a dev dependency.

And I will remove prop-types in the next version.