search

nanxstats / ggsci

🦄 Scientific journal and sci-fi themed color palettes for ggplot2
https://nanx.me/ggsci/
GNU General Public License v3.0
664 stars 71 forks source link

Other Hallmarks of Cancer colors #6

Closed jhrcook closed 5 years ago

jhrcook commented 5 years ago

So it turns out that COSMIC used different shades of the same colors for the Hallmarks of Cancer than in Weinberg's "Hallmarks of cancer: the next generation" paper. I would like to add Weinberg's (they are lighter shades and thus easier to use in plots), but am not sure where. Do you think this is a worthwhile addition and, if so, where would you like me to add them (in the COSMIC palette or a new palette)?

Thanks, Josh Cook

nanxstats commented 5 years ago

@jhrcook -please check this out: https://nanx.me/ggsci/reference/pal_uchicago.html. It is preferable to have them as separate options under a single palette, and (if necessary) show them all in the code example, readme, and vignette.

jhrcook commented 5 years ago

Great idea! Will do.

- Josh Cook

nanxstats commented 5 years ago

Solved by https://github.com/road2stat/ggsci/pull/7.