search

nanxstats / liftr

🐳 Containerize R Markdown documents for continuous reproducibility
https://nanx.me/liftr/
GNU General Public License v3.0
170 stars 20 forks source link

added paramter for --no-cache #19

Closed behrica closed 7 years ago

behrica commented 7 years ago

Fixes #18

behrica commented 7 years ago

My main use case is now satisfied, in the sense that I can use 'drender' , and it goes very fast, as it only runs 'knitr' during the drender() call, all the other docker layers are cached.

I get this by using both parameters in drender(....,reset=F, noCache=F)

But it is maybe confusing, to have both paramters, with 4 possible combinations...

If I would change anything in the 'liftr: ' part of the docker file, I would run it with: drender(...,reset=T,noCache=T) in ordder to rebuild everything.

So why would we need 2 boolean parameters ?

Maybe it is just because I dont understand while we have parameters 'reset', and what it does...

nanxstats commented 7 years ago

@behrica - thanks a lot for the PR(s), this is a very good point.

The point of having reset was to offer a way to clean things up after the document is rendered. Though it also seems to me today that this might not be an optimal design.

I will accept this PR (though with a little naming scheme change on noCache), remove the argument reset, and make a separate clean-up function.