Closed stephlocke closed 6 years ago
@stephlocke - thanks for reporting the issue. It seems legit, though the purpose of run_arg
is merely for specifying additional docker run
arguments, instead of replacing all of them.
I guess a more proper solution could be setting the environment variable $USER
in the Dockerfile. You can include any of such snippets by using the metadata include
when you use liftr::lift()
to generate the Dockerfile.
Good idea!
Feature Request
When someone provides values to
run_args
it will remove any default args thatrender_docker()
may have included.Background
Docker is a wonderful thing 😂 I'm using Docker for Windows and it's probably the reason my docker containers don't contain the env var $USER. As such,
render_docker()
fails. I tried working around this by using the predefined user nameroot
based on runningwhoami
in containers.Repro
Unfortunately, this gets added but so does the existing argument flag and values that you provide by default.