search

naobservatory / mgs-pipeline

MIT License
4 stars 2 forks source link

running prepare-dashboard.sh on main without other edits. #53

Closed simonleandergrimm closed 6 months ago

simonleandergrimm commented 7 months ago

@jeffkaufman I ran prepare-dashboard.sh on a branch that mirrors up-to-date version of main. I am still not sure where the differences originate from.

jeffkaufman commented 7 months ago

This is quite strange: I don't know why there are so many additions across bioprojects.

I can look at this when I get back (Weds) or you and others working this week can look into why it's happening.

simonleandergrimm commented 7 months ago

It’s not super urgent. I can take another look and if I don’t resolve it we can look into it together on Weds.

On Sun, 3 Dec 2023 at 9:58 PM Jeff Kaufman @.***> wrote:

This is quite strange: I don't know why there are so many additions across bioprojects.

I can look at this when I get back (Weds) or you and others working this week can look into why it's happening.

— Reply to this email directly, view it on GitHub https://github.com/naobservatory/mgs-pipeline/pull/53#issuecomment-1837761510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN7ASMUFFP6R6S7VGQZIPGTYHU355AVCNFSM6AAAAABAAJGVRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG43DCNJRGA . You are receiving this because you authored the thread.Message ID: @.***>

simonleandergrimm commented 7 months ago

This is quite strange: I don't know why there are so many additions across bioprojects.

I can look at this when I get back (Weds) or you and others working this week can look into why it's happening.

FYI, I created a new directory with a clean version of mgs-pipeline. Upon running prepare-dashboard.sh I still get the following when running git status:

On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   dashboard/comparison_sample_counts.PRJEB12466.json
    modified:   dashboard/comparison_sample_counts.PRJEB13831.json
    modified:   dashboard/comparison_sample_counts.PRJEB13832.json
    modified:   dashboard/comparison_sample_counts.PRJEB13833.json
    modified:   dashboard/comparison_sample_counts.PRJEB14051.json
    modified:   dashboard/comparison_sample_counts.PRJEB27054.json
    modified:   dashboard/comparison_sample_counts.PRJEB27621.json
    modified:   dashboard/comparison_sample_counts.PRJEB28033.json
    modified:   dashboard/comparison_sample_counts.PRJEB34633.json
    modified:   dashboard/comparison_sample_counts.PRJEB40798.json
    modified:   dashboard/comparison_sample_counts.PRJEB40815.json
    modified:   dashboard/comparison_sample_counts.PRJEB40816.json
    modified:   dashboard/comparison_sample_counts.PRJEB49260.json
    modified:   dashboard/comparison_sample_counts.PRJEB51229.json
    modified:   dashboard/comparison_sample_counts.PRJNA438174.json
    modified:   dashboard/comparison_sample_counts.PRJNA527877.json
    modified:   dashboard/comparison_sample_counts.PRJNA603194.json
    modified:   dashboard/comparison_sample_counts.PRJNA645711.json
    modified:   dashboard/comparison_sample_counts.PRJNA661613.json
    modified:   dashboard/comparison_sample_counts.PRJNA681566.json
    modified:   dashboard/comparison_sample_counts.PRJNA729801.json
    modified:   dashboard/comparison_sample_counts.PRJNA774620.json
    modified:   dashboard/comparison_sample_counts.PRJNA812772.json
    modified:   dashboard/comparison_sample_counts.PRJNA853368.json
    modified:   dashboard/comparison_sample_counts.PRJNA875025.json
    modified:   dashboard/comparison_sample_counts.PRJNA924011.json
    modified:   dashboard/comparison_sample_counts.PRJNA943189.json
    modified:   dashboard/comparison_sample_counts.PRJNA966185.json
    modified:   dashboard/comparison_taxid_classifications.json
    modified:   dashboard/comparison_taxids.txt
    modified:   dashboard/taxonomic_names.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    bioprojects/PRJNA853368/metadata/head.n_reads
    bioprojects/PRJNA853368/metadata/tail.n_reads
    bioprojects/PRJNA853368/metadata/test.n_reads

no changes added to commit (use "git add" and/or "git commit -a")
jeffkaufman commented 7 months ago

After 2e34c20, when I run it on main with no edits it gives me no changes; is that also what you see now?

simonleandergrimm commented 6 months ago

After 2e34c20, when I run it on main with no edits it gives me no changes; is that also what you see now?

Yep this is also what I see!

simonleandergrimm commented 6 months ago

Closing this PR given that Jeff's fix resolved this issue.