naofireblade / homebridge-neato

A Neato vacuum robot plugin for homebridge.
MIT License
69 stars 18 forks source link

Support for NoGo Lines #13

Closed DJay-X closed 5 years ago

DJay-X commented 6 years ago

I will receive my first Neato in a couple of days. The D7 Connected. And I was happy to see that there is already a Homebridge Plugin. Thanks for your work and sharing. πŸ‘πŸ» I'll give some feedback when my Neato has arrived and is connected. πŸ˜ƒ

naofireblade commented 6 years ago

That would be great. Thanks!

DJay-X commented 6 years ago

Hey... I was happy to receive my D7 just before the Easter Hollidays. πŸ€— And of course I already installed your plugin. At the first sight, the main features are working. πŸ‘πŸ» But there are maybe some D7 specific and new things.

  1. When starting the D7 with the plugin switch (Clean), the Neato app shows that the cleaning process is startet but with No-Go Lines deactivated. This is not good, because the No-Go Lines are one of the new main and important features. In comparison when starting the D7 out of the Neato App, No-Go Lines are correctly activated.

1_no-go lines

  1. When starting D7 with the plugin switch (Clean), the switch Eco Mode is off, although the D7 is always set by default to Eco mode and the Neato App is showing the Eco Icon.

2_eco mode

For my short test, that's it for the moment. ;) I hope this helps and if there is anything I can do to help investigate or test, of course please let me know.

Thanks for the time you are investing and for your work. Daniel

Be2daErtin commented 6 years ago

I'm wondering if the app acts as the brain for the robot. I.e where it should and should not go. I got my D7 as well. Read something about it using beehive for maps..... Will check it out.

naofireblade commented 6 years ago

Thanks for the detailed report and the screenshots.

  1. I will look into the no-go-lines. That will require an update of the underlying botvac node.
  2. This is due to a limitation of the neato api. I cannot set or read the eco mode via the api. I just can start the cleaning process with eco mode on/off. Therefore the switch in homebridge is asynchronus to the neato app. But I think the neato app remembers the mode after starting a cleaning process.
DJay-X commented 6 years ago

@naofireblade Thanks for the time you are investing. It would be fantastic if I could start Neato D7 with HomeKit (Siri) with the clean switch, and the Neato would just start in its default setting which is always eco in the neato App and also of course ne no-go lines are noticed. Meaning "on" in HomeKit is just "on" with the default settings in the neato App. Thanks in advance.

FrothyDog commented 6 years ago

Has any progress been made on the no-go lines option? I just got my D7 yesterday and would like to see this feature supported as well.

naofireblade commented 6 years ago

I had no time for this yet. If anybody is able to code js, I would appreciate a pull request :) .

DJay-X commented 6 years ago

@naofireblade Unfortunately it looks like you are still the man of the hour. ;) Hopefully you'll find some time in the near future for ongoing development in regard of the no-go-lines. Thanks again for considering this.

naofireblade commented 5 years ago

My D5 will get an update to support no-go-lines this fall. Then I can finally fix this.

naofireblade commented 5 years ago

Still waiting for the firmware update with no-go-lines that is scheduled for "fall 2018" :/ .

ifeign commented 5 years ago

I was just on the phone with Neato support for something unrelated, but the rep mentioned that they just released the no-go line update for the D5 today.

Edit: https://www.androidheadlines.com/2018/11/neato-botvac-d5-connected-boundaries.html

naofireblade commented 5 years ago

Yes yes yes :) . I got a mail also but had no update available in the app last night. And no firmware file to download on the website. I will check it again today.

naofireblade commented 5 years ago

My D5 finally got the update. Heβ€˜s discovering my home right now. I hope I will find some spare time to update the plugin and the node api within the next 2 weeks.

ifeign commented 5 years ago

Yay! I hope you can figure it out. On Sat, Nov 10, 2018 at 2:31 AM Arne notifications@github.com wrote:

My D5 finally got the update. Heβ€˜s discovering my home right now. I hope I will find some spare time to update the plugin and the node api in the next 2 weeks.

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/naofireblade/homebridge-neato/issues/13#issuecomment-437574184, or mute the thread https://github.com/notifications/unsubscribe-auth/Aeyz4Cj0Ony8wi9YROndxvbFdS6LJ1Qxks5utqsDgaJpZM4S_AWp .

naofireblade commented 5 years ago

It's working pretty well in my development environment already. I will fix some more stuff in this release:

ifeign commented 5 years ago

Wonderful! I was worried that the no-go lines wouldn't work with Homebridge because it seemed so tied to the Neato app itself. Glad I was wrong. On Sat, Nov 10, 2018 at 9:53 AM Arne notifications@github.com wrote:

It's working pretty well in my development environment already. I will fix some more stuff in this release:

  • setting care-navigation and nogolines in the home app instead of the config file
  • loading eco-mode, care-navigation and nogolines options from the last run (so the options should be consistent if you switch between using the neato app and the home app)

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/naofireblade/homebridge-neato/issues/13#issuecomment-437602954, or mute the thread https://github.com/notifications/unsubscribe-auth/Aeyz4EbPzsCJuTK9tWn6_cZq5GcbHe1Sks5utxKlgaJpZM4S_AWp .

DJay-X commented 5 years ago

Can't wait. Thanks @naofireblade And I hope it will also work with my D7. After you release the latest Version, I immediately will give a try. :)

alecc131 commented 5 years ago

Awesome! When will this be pushed to npm? @naofireblade

naofireblade commented 5 years ago

I completed the new version yesterday and had to wait for my pull request of the node api to be merged and pushed to npm as well. That happened now and I can push my plugin this evening.

naofireblade commented 5 years ago

The plugin is now published to npm in version 0.5.0.

ifeign commented 5 years ago

Awesome! I'm going to test it out.

DJay-X commented 5 years ago

Awesome! I already tested it. ;) First, thanks a lot @naofireblade Really helps a lot now with starting Neato by calling Siri and the D7 runs as always with no-go lines active Looks great all-in-all. Works with my BotVacD7Connected', firmware: '4.2.3-153

What I noticed is just some delay (rings) after I start, pause or send Neato back to the dock. Not sure if this "okay" and meant to be. I also got an error message on the Neato App which I never had before. Both Screenshots enclosed.

Also I noticed in the Homebridge Journal that there is a lot going on every single minute, even when Neato is in the dock.

Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]: { version: 1,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   reqId: '1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   result: 'ok',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   data: {},
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   error: null,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   alert: null,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   state: 1,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   action: 0,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   cleaning:
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:    { category: 4,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      mode: 1,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      modifier: 1,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      navigationMode: 1,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      mapId: '',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      spotWidth: 0,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      spotHeight: 0 },
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   details:
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:    { isCharging: false,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      isDocked: true,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      isScheduleEnabled: true,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      dockHasBeenSeen: false,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      charge: 95 },
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   availableCommands:
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:    { start: true,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      stop: false,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      pause: false,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      resume: false,
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      goToBase: false },
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   availableServices:
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:    { findMe: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      generalInfo: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      houseCleaning: 'basic-3',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      IECTest: 'advanced-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      logCopy: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      manualCleaning: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      maps: 'macro-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      preferences: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      schedule: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      softwareUpdate: 'basic-1',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      spotCleaning: 'basic-3',
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:      wifi: 'basic-1' },
Nov 15 20:56:38 raspberrypi-3BPlus homebridge[12369]:   meta: { modelName: 'BotVacD7Connected', firmware: '4.2.3-153' } }

I'll have an eye on that or maybe this is something you want to investigate. Please of course let me know. Happy to help.

napkin 15 11 18 7 31 23 pm

Is shown in Neato App when using the HomeKit Switch to send Neato to Dock. napkin 15 11 18 8 59 58 pm

naofireblade commented 5 years ago

The long output in the journal is my bad, I accidentally left a console log in the node api. I made a pull request to fix that.

There should be only one ring on the action you perform (e.g. start cleaning) for about 2 seconds until the robot starts. How long do you have these rings? Do they occur after every command or just sometimes?

Do you have set the "refresh" parameter? If not, no updates should happen after cleaning is done. Let's wait until the node api update is pushed and I can update my plugin. Then it would be very helpful if you could start the plugin in debug mode.

naofireblade commented 5 years ago

Ok I released 0.5.1 to get rid of the long console log. Could you please start homebridge with this option to further investigate your problems? DEBUG=homebridge-neato

DJay-X commented 5 years ago

After updating to 0.5.1 everything is working now perfect since yesterday. So I think all good for now. πŸ‘πŸ» Thank you so much @naofireblade for the time and work you are investing and for sharing with us. ⭐️⭐️⭐️⭐️⭐️

naofireblade commented 5 years ago

You're welcome. I'm glad it's working well. I will close this and reopen it if any problems with the no go lines occur.