search

naofireblade / homebridge-neato

A Neato vacuum robot plugin for homebridge.
MIT License
69 stars 18 forks source link

Add display language selection #65

Closed himbeles closed 3 years ago

himbeles commented 3 years ago

Adds Language selection (also via homebridge UI) for English, German, French. Picked from https://github.com/himbeles/homebridge-kobold . Solves #59 .

naofireblade commented 3 years ago

Thanks for the PR! I'm currently rewriting the complete plugin for dynamic platform and typescript. Could you adapt your PR for the branch https://github.com/naofireblade/homebridge-neato/tree/dynamic-platform ?

naofireblade commented 3 years ago

Also for easier PRs from users it would be cool to have the language properties in separate files.

himbeles commented 3 years ago

Nice! Also I see mostly async/await instead of callbacks now 👍 . Don't have too much free time though before real-life home office starts :) Will try on one of the coming weekends.

naofireblade commented 3 years ago

Awesome. I will release a beta as soon as my PRs for the node-botvac library get merged.

himbeles commented 3 years ago

Closed in favor of #66