search

naofireblade / homebridge-weather-plus

A comprehensive weather plugin for homebridge.
MIT License
316 stars 63 forks source link

Fixes negative value issue for temperature based services #167

Closed kylerove closed 3 years ago

kylerove commented 3 years ago

DewPoint, TemperatureMin, and ApparentTemperature can have negative values. The accessory would become "unresponsive" when negative values were returned. Suggested changes provided by @frans2526.

naofireblade commented 3 years ago

This should already be handled here: https://github.com/naofireblade/homebridge-weather-plus/blob/ad25e6706a79dcabf45d7f98c9936484a8f15034/util/characteristics.js#L216

I will check why it’s not working for some. Maybe because of the unit conversion because HomeKit always uses C for all temperatures.

frans2526 commented 3 years ago

Hello, Yes this what I seen when I read the code but for a reason I ignore the widget (I don’t know how to call it) is not initialise correctly. The only place I found was directly in the index.js which obviously is not the good solution. I will be happy to assist if you need ;) By the way this is a really great plugin!

naofireblade commented 3 years ago

I found the reason why the setting in characteristics.js was not working and fixed it in v3.2.3. Format was integer instead of float. HomeKit expects float for temperature sensors. Thanks for raising awareness for the issue and submitting a fix for other users while a new release was not available 👍 .