search

naofireblade / homebridge-weather-plus

A comprehensive weather plugin for homebridge.
MIT License
311 stars 61 forks source link

Fix Tempest breakage #280

Closed dacarson closed 5 months ago

dacarson commented 5 months ago

Fix #278, add missing variable declaration.

Lived on 3.3.2 with this change and only this change for two days. During which time it rained. I verified that this fix will correct the breakage introduced in 278, and I have not observed any other issues.

dacarson commented 5 months ago

Found an additional error now that it has been raining for a while. There is code to handle the case that if several minutes pass between observations, then clear out the old data in the skipped minutes. This was also clearing the last minute, so each time it clicked over a minute, it would erase the last one. This is fixed by clearing just the minutes that are actually skipped, one passed the last recorded to the current minute.

dacarson commented 5 months ago

@wimleers I am embarrassed by the obvious breakage I introduced. Sorry for that. With the continued storms in California (https://www.sfgate.com/weather/article/worst-bay-area-storm-to-come-18647650.php), I have been able to continue testing the changes here and I can report that it is working well.

Can I please get this change merged?

naofireblade commented 5 months ago

No worries. Thanks for your fix :)

wimleers commented 5 months ago

Thank you, @dacarson ! My Tempest is still down because of the absence of sunshine here in Belgium, and I haven't connected the battery pack yet 🙈

dacarson commented 5 months ago

Can I get it tagged as a release too? @naofireblade? 🙏

naofireblade commented 5 months ago

I forgot the tag, but I pushed to npm right after the merge.

wimleers commented 4 months ago

Thanks!