naofireblade / homebridge-weather-plus

A comprehensive weather plugin for homebridge.
MIT License
314 stars 63 forks source link

Weather Underground Plugin Error #56

Closed fubu2k closed 5 years ago

fubu2k commented 5 years ago

Hi,

iam getting the following error since updating the homebridhe weather plug plugin to version 2.7.0:

/homebridge/node_modules/homebridge-weather-plus/api/weatherunderground.js:78 report.AirPressure = parseInt(values.pressure_mb); ^ TypeError: Cannot read property 'pressure_mb' of undefined at WundergroundAPI.parseReport (/homebridge/node_modules/homebridge-weather-plus/api/weatherunderground.js:78:46) at WundergroundAPI. (/homebridge/node_modules/homebridge-weather-plus/api/weatherunderground.js:58:39) at Request._callback (/homebridge/node_modules/wundergroundnode/lib/wundergroundnode.js:137:26) at Request.self.callback (/homebridge/node_modules/request/request.js:185:22) at Request.emit (events.js:189:13) at Request. (/homebridge/node_modules/request/request.js:1161:10) at Request.emit (events.js:189:13) at IncomingMessage. (/homebridge/node_modules/request/request.js:1083:12) at Object.onceWrapper (events.js:277:13) at IncomingMessage.emit (events.js:194:15)

simont77 commented 5 years ago

It happened also to me, and I've never had this issue before. I suppose it is related to Wunderhround shutting down its old free API keys.

naofireblade commented 5 years ago

Jepp, looks like it's time to mitigate to dark sky. Should we remove wunderground from the readme (keep the code but print a warning if the response is empty)? I think nobody likes to pay for a weather service when good free alternatives exist.

fubu2k commented 5 years ago

the other weather services are not able to send "solar radiation data" :-(

ctgreybeard commented 5 years ago

I still use weather underground as a paying member but experienced this this morning due, probably, to some slightly corrupted data. This should NOT crash Homebridge whether the data is good or bad. I don't think the discussion of the status of weather underground is relevant, it is the error/crash that should be addressed. No program that pulls external data should crash like this. It should gracefully handle it.

angladacamps commented 5 years ago

I'm experiencing this error too, and got a paid subscription. I'm seeing now that there's a mainteinance interruption, maybe it's this the reason it's crashing? Anyway, I'm absolutely agree with ctgreybeard. NO PLUGIN SHOULD CRASH for this reason. Please awaiting for fix. thank you

ctgreybeard commented 5 years ago

Well, they finally shut the API down. WU is officially dead I guess. End of Service for the Weather Underground API

angladacamps commented 5 years ago

Ok, sad news...

El El mar, 26 mar 2019 a las 4:52, Bill Waggoner notifications@github.com escribió:

Well, they finally shut the API down. WU is officially dead I guess. End of Service for the Weather Underground API https://apicommunity.wunderground.com/weatherapi/topics/end-of-service-for-the-weather-underground-api

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/naofireblade/homebridge-weather-plus/issues/56#issuecomment-476465264, or mute the thread https://github.com/notifications/unsubscribe-auth/AtbE68zOod7PeqZS8pPvYfx1uT8W4EsEks5vaZl-gaJpZM4bgX_J .

-- Pedro Anglada Camps

ctgreybeard commented 5 years ago

I got a response from them and there is a new API but it only available for PWS system contributors as well as corporate account holders. That doesn't make it generally useful but I am going to rework the weatherunderground code to account for the new API. At least it will be useable for those of us that submit PWS data.

It may take a while but I'll submit a pull request when I have it done.

angladacamps commented 5 years ago

Yesssssss!!!!! Thank you thank you !!!!! I own a pws and i push data to wu.

Thank you again !

El El mar, 26 mar 2019 a las 17:35, Bill Waggoner notifications@github.com escribió:

I got a response from them and there is a new API but it only available for PWS system contributors as well as corporate account holders. That doesn't make it generally useful but I am going to rework the weatherunderground code to account for the new API. At least it will be useable for those of us that submit PWS data.

It may take a while but I'll submit a pull request when I have it done.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/naofireblade/homebridge-weather-plus/issues/56#issuecomment-476735314, or mute the thread https://github.com/notifications/unsubscribe-auth/AtbE64CIhFmI7MgiXLuC1t-mBkBY6-W1ks5vakxkgaJpZM4bgX_J .

-- Pedro Anglada Camps

naofireblade commented 5 years ago

Fixed in release v2.7.1