search

naofireblade / homebridge-weather-plus

A comprehensive weather plugin for homebridge.
MIT License
314 stars 63 forks source link

Round Wind Speeds to two decimal places #88

Closed joconor closed 4 years ago

joconor commented 4 years ago

Uses exponential notation to accurately round numbers in mtos2kmh & mtos2mih functions. Addresses issue #86

joconor commented 4 years ago

@naofireblade Hey. I notice you've already committed a fix for #86. The usual multiply & divide technique for rounding can lead to incorrect rounding in javascript. The technique I use here will produce correct results in all cases. Still, the cases where multiply & divide provide an incorrect answer may be enough of an edge case that you prefer to go with the changes you've already made. In that case, feel free to reject this PR.

naofireblade commented 4 years ago

Awesome! That PR is very welcome. I will use it in the next release.

naofireblade commented 4 years ago

Released in v3.0.4