Open GoogleCodeExporter opened 8 years ago
Stephan - interesting suggestions. Can you explain a little bit more what this
does
that add() doesn't already do? If you call add() using a key (newLocation) that
has
previously been stored, it will simply update the existing key with your new
historyData. You can see this at work in the new test page in the 0.6 beta.
Please
let me know if I'm missing something here. At the very least I should work the
existence of this functionality into the release notes/comments/documentation.
Original comment by bdpathfi...@gmail.com
on 24 Oct 2007 at 8:54
Yes, I forgot to mention -- there is a flicker in the URL bar (sometimes) when
using
add (not the suggested update) -- in my Firefox. I put together a patch against
RSH0.6PC.zip to demonstrate
Stephan
diff RSH0.6/rsh0.6.js RSH0.6update/rsh0.6.js
53a54,59
> update: function(newLocation, historyData) {
> historyStorage.put(newLocation, historyData);
> // don't know what happened to this function - SW
> // if (this.isInternetExplorer())
> // this.iframe.src = "blank.html?" + newLocation;
> },
diff RSH0.6/rshTestPage.html RSH0.6update/rshTestPage.html
190a191
> var lastAddedLocation
196a198
> lastAddedLocation = a[0]
202a205,216
>
> }
> updateHistoryEvent_I = function() {
> if(!lastAddedLocation) {
> alert('No history data to update')
> return
> }
>
> testUpdateEntry = 'Add-Update at ' + new Date()
> dhtmlHistory.add(lastAddedLocation,testUpdateEntry)
> var msg = "A history event has been added: [newLocation=" +
lastAddedLocation + " | historyData=" + testUpdateEntry + "]";
> log(msg, "logDH");
204a219,229
> updateHistoryEvent_II = function() {
> if(!lastAddedLocation) {
> alert('No history data to update')
> return
> }
>
> testUpdateEntry = 'Update-Update at ' + new Date()
> dhtmlHistory.update(lastAddedLocation,testUpdateEntry)
> var msg = "A history event has been added: [newLocation=" +
lastAddedLocation + " | historyData=" + testUpdateEntry + "]";
> log(msg, "logDH");
> }
281a307,308
> | <a href="javascript:updateHistoryEvent_I();">update history - with
add</a>
> | <a href="javascript:updateHistoryEvent_II();">update history - with
update</a>
Original comment by stephanw...@gmail.com
on 25 Oct 2007 at 5:01
Original comment by bdpathfi...@gmail.com
on 28 Oct 2007 at 6:02
Original comment by bdpathfi...@gmail.com
on 5 Nov 2007 at 6:34
Original comment by bdpathfi...@gmail.com
on 14 Nov 2007 at 12:58
gggggggg
Original comment by kumar.sh...@gmail.com
on 3 Jan 2012 at 5:14
Original issue reported on code.google.com by
stephanw...@gmail.com
on 16 Oct 2007 at 4:25