naojsoft / qplan

Other
2 stars 4 forks source link

OB scheduled after the target sets and twilight begins #22

Open monodera opened 5 years ago

monodera commented 5 years ago

As I reported earlier, there is a case that an OB is scheduled after it becomes below 30 degree and after twilight starts. It's still there after updating to the latest commit (aa9521ad23d9e5426951b257da30eb447401f80d).

To reproduce the issue, you can go to Nextcloud/subaru-support-queue-shared/users/monodera/strange_plan_test/ and run qplan with qplan -i ./ -c executed_obs.json --loglevel=10 --stderr. Then press Load Info and Build Schedule.

In my environment, the resulting schedule is the following.

--- NIGHT OF 2019-05-04 --- filters: r2
Queue prepared at: 2019-05-17 17:42:07
Date              ObsBlk    Code            Program  Grade   Rank    Time Target     Filter   AM  Comment
2019-05-04 00:35  ob87      ob87          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk28_r1: 
2019-05-04 00:35  ob88      ob88          S19A-OT06      A   9.50    2.05 calib for  r2      2.0  Calibration for ob44
2019-05-04 00:37  ob44      Chunk28_r1    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 01:08  ob89      ob89          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob44
2019-05-04 01:08  ob90      ob90          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk28_r2: 
2019-05-04 01:08  ob45      Chunk28_r2    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 01:40  ob91      ob91          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob45
2019-05-04 01:40  ob92      ob92          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk28_r3: 
2019-05-04 01:40  ob46      Chunk28_r3    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 02:12  ob93      ob93          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob46
2019-05-04 02:12  ob94      ob94          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk28_r4: 
2019-05-04 02:12  ob47      Chunk28_r4    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 02:43  ob95      ob95          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob47
2019-05-04 02:43  ob96      ob96          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk30_r1: 
2019-05-04 02:43  ob97      ob97          S19A-OT06      A   9.50    0.89 calib for  r2      2.0  Calibration for ob65
2019-05-04 02:44  ob65      Chunk30_r1    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 03:16  ob98      ob98          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob65
2019-05-04 03:16  ob99      ob99          S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk30_r2: 
2019-05-04 03:16  ob66      Chunk30_r2    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 03:48  ob100     ob100         S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob66
2019-05-04 03:48  ob101     ob101         S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk30_r3: 
2019-05-04 03:48  ob67      Chunk30_r3    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 04:19  ob102     ob102         S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob67
2019-05-04 04:19  ob103     ob103         S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Setup OB: S19A-OT06 Chunk30_r4: 
2019-05-04 04:19  ob68      Chunk30_r4    S19A-OT06      A   9.50   31.67 SSP_WIDE   r2      2.0  
2019-05-04 04:51  ob104     ob104         S19A-OT06      A   9.50    0.02 SSP_WIDE   r2      2.0  Teardown for ob68
2019-05-04 04:51  None    

2 targets  1 filter exch  Time: avail=275.00 sched=256.54 unsched=18.46 min

Here, the last schduled OB, Chunk30_r4 shouldn't be there because the field is already below the requested minimum elevation of 30 degree (i.e., airmass=2) and also it's already twilight time.

If change the start time in the Schedule tab from 00:35:00 to something else, even 1 second, like 00:35:01, Chunk30_r4 is not scheduled.

I'm using Python 3.5.6 installed with conda with the latest packages required for qplan.