naokazuterada commented 6 years ago

Hi, @jonasbn !

I finally got ready for MarkdownTOC v3.0. As I mentioned before, it contains some breaking changes. I summarized them in the Upgrade Guide on message file.

Any other changes are also summarized on #110 .

I am very grateful if you give me your opinion on especially English sentences and how to organize documents. Please let me know if you feel strange or confusing points. I think that you are busy though, I hope that you could take a time.

codecov[bot] commented 6 years ago

Codecov Report

Merging #120 into master will decrease coverage by 0.72%. The diff coverage is 92.52%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   93.25%   92.52%   -0.73%     
==========================================
  Files           1        8       +7     
  Lines         326      388      +62     
==========================================
+ Hits          304      359      +55     
- Misses         22       29       +7

Impacted Files	Coverage Δ
markdowntoc/markdowntoc_update.py	`100% <100%> (ø)`
markdowntoc/__init__.py	`100% <100%> (ø)`
__init__.py	`100% <100%> (ø)`
markdowntoc/autorunner.py	`50% <50%> (ø)`
markdowntoc/base.py	`66.66% <66.66%> (ø)`
markdowntoc/id.py	`91.22% <91.22%> (ø)`
markdowntoc/util.py	`95% <95%> (ø)`
markdowntoc/markdowntoc_insert.py	`95.27% <95.27%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97e8952...c87a679. Read the comment docs.

naokazuterada commented 6 years ago

Sorry, I found the parts to update, so I fixed it.

jonasbn commented 6 years ago

Hi @naokazuterada

I will have a look ASAP

naokazuterada commented 6 years ago

@jonasbn Thank you so much for your polite and quick review. I've done correcting, and will go for release soon. 👍

naokazuterada / MarkdownTOC

v3.0 #120

Codecov Report