search

naokazuterada / MarkdownTOC

SublimeText3 plugin which generate a table of contents (TOC) in a markdown document.
https://packagecontrol.io/packages/MarkdownTOC
MIT License
301 stars 48 forks source link

Remove `.python-version` #158

Closed FichteFoll closed 4 years ago

FichteFoll commented 4 years ago

On ST4 builds, the plugin is ignored entirely because the .python-version file is interpreted and only supports 3.3 and 3.8 for the two available runtimes in that version. The exact exception is as follows:

ignoring plugins in package MarkdownTOC, version file Packages/MarkdownTOC/.python-version contains an invalid version: 3.7.1\x0a

The file was added in https://github.com/naokazuterada/MarkdownTOC/commit/f97f221dc267dfed2dba1e7cacea4253031f30f7, but I don't see a particular reason for it.

naokazuterada commented 4 years ago

Thank you for reporting!

This file is for code style. So I'd like to keep the version number. I want to know a specific version that works in ST4 environment and also works fine for "black". Will it work if I set it to 3.8.3? If you tell me the version that works, I will change it to that value. Or could you create a PR with the changed version ?

FichteFoll commented 4 years ago

I know that 3.8 works, if that's fine for you. The version ST4 bundles is 3.8.3 currently and will likely increase, but I don't see much of a point in pinning the patch version since that will likely be updated in the future.

naokazuterada commented 4 years ago

@FichteFoll @nickhstr please check working correctly.

FichteFoll commented 4 years ago

Should work like that.

nickhstr commented 4 years ago

@naokazuterada thanks for the quick turn-around time on merging the PR! It seems to have done the trick in ST4. Looking forward to its release on Package Control.

naokazuterada commented 3 years ago

Thank you for all!

Released 4.1.1.