naoki-egami / DIDdesign

R package DIDdesign: Analyzing Difference-in-Differences Design
GNU General Public License v2.0
35 stars 7 forks source link

Recent PR on `skip_standardize` causing `sa_check()` to fail #38

Closed sou412 closed 9 months ago

sou412 commented 9 months ago
sou412 commented 9 months ago

Test with the example on Readme:

> set.seed(1234)
> check_sa <- did_check(
+   formula = log_expenditure ~ treatment,
+   data    = paglayan2019,
+   id_unit = "id_subject",
+   id_time = "id_time",
+   design  = "sa",
+   option  = list(n_boot = 10, parallel = TRUE, thres = 1, lag = 1:5)
+ )
> summary(check_sa)
── Estimates for assessing parallel trends assumption ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
  estimate lag std.error EqCI95_LB EqCI95_UB
1 -0.00267   1   0.01116    -0.156     0.156
2 -0.01245   2   0.00633    -0.131     0.131
3  0.00227   3   0.00950    -0.105     0.105
4 -0.00758   4   0.01205    -0.155     0.155
5 -0.01070   5   0.00908    -0.124     0.124
> set.seed(1234)
> check_sa <- did_check(
+   formula = log_expenditure ~ treatment,
+   data    = paglayan2019,
+   id_unit = "id_subject",
+   id_time = "id_time",
+   design  = "sa",
+   option  = list(n_boot = 10, parallel = TRUE, thres = 1, lag = 1:5, skip_standardize = TRUE)
+ )
> summary(check_sa)
── Estimates for assessing parallel trends assumption ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
  estimate lag std.error EqCI95_LB EqCI95_UB
1 -0.00267   1   0.01116   -0.0210    0.0210
2 -0.01245   2   0.00633   -0.0229    0.0229
3  0.00227   3   0.00950   -0.0179    0.0179
4 -0.00758   4   0.01205   -0.0274    0.0274
5 -0.01070   5   0.00908   -0.0256    0.0256