`did_plot_selection` needs `selection` from `did_parametric_rcs`

naoki-egami / DIDdesign

R package DIDdesign: Analyzing Difference-in-Differences Design

GNU General Public License v2.0

35 stars 7 forks source link

`did_plot_selection` needs `selection` from `did_parametric_rcs` #6

Closed naoki-egami closed 5 years ago

naoki-egami commented 5 years ago

I got the following error. Error in did_plot_selection(fit_new) : selection does not exsit. it seems that did_parametric_rcs output does not have selection.

It is written more in the entire code that reproduces the error. code in double_did

sou412 commented 5 years ago

@naoki-egami replicated the error and it has been fixed. I also updated the code in double_did a little bit.