fix specified bluetooth mac address, ds4drv use PR 044596a

naoki-mizuno / ds4_driver

DualShock 4 driver for both ROS1 and ROS2

http://wiki.ros.org/ds4_driver

85 stars 53 forks source link

fix specified bluetooth mac address, ds4drv use PR 044596a #11

Closed sss22213 closed 3 years ago

sss22213 commented 3 years ago

fix specified bluetooth mac address, ds4drv use PR 044596a

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging f2b61b9acd08221b375d299ec5edec91e6312d53 into 31253666fe0c565005f138fd2769d90e49efc56b - view on LGTM.com

new alerts:

1 for Testing equality to None
1 for Unnecessary 'else' clause in loop

naoki-mizuno commented 3 years ago

Thanks for your contribution! However, I didn't quite understand why this change is necessary. Looking at this PR and the changes in https://github.com/naoki-mizuno/ds4drv/pull/1, it seems like you're doing the same thing (i.e. looping until the desired address is found) as what's done currently.

Please describe your use case and why this change is necessary.

Thanks!