noetic support - Githubissues

naoki-mizuno / ds4_driver

DualShock 4 driver for both ROS1 and ROS2

http://wiki.ros.org/ds4_driver

85 stars 53 forks source link

noetic support #12

Closed sss22213 closed 3 years ago

sss22213 commented 3 years ago

add noetic support

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging d3f6e9058cd340d1609f9639235c55fe7f7239ef into 31253666fe0c565005f138fd2769d90e49efc56b - view on LGTM.com

new alerts:

1 for Testing equality to None
1 for Unnecessary 'else' clause in loop

vinnnyr commented 3 years ago

Hey all, do you think this is going to merged in soon? or should I fork off of this branch if I want noetic support?

naoki-mizuno commented 3 years ago

I'll merge this into noetic-devel branch once:

f2b61b9acd08221b375d299ec5edec91e6312d53 is removed and
the shebangs are changed to #!/usr/bin/env python3.

I currently don't have a noetic environment that I can test this on, so I'll also need someone who can confirm that the above change causes no problems (although I doubt it would).