naoki-mizuno / ds4_driver

DualShock 4 driver for both ROS1 and ROS2
http://wiki.ros.org/ds4_driver
85 stars 53 forks source link

updated timer creation to match the documented and correct way specified in latest rclpy version #18

Closed geoporus1 closed 3 years ago

geoporus1 commented 3 years ago

Addresses #17:

Later edits:

naoki-mizuno commented 3 years ago

Thanks! I'll try out your patch once I get the chance. In the mean time, I added some minor comments.

geoporus1 commented 3 years ago

@naoki-mizuno Thank you for the quick reply! I will address your comments and change the things according to your advice! Hope that you will soon get to try out the patch and we can merge it! Best of luck to you and hope to hear from you soon! :)

naoki-mizuno commented 3 years ago

I was able to confirm that 1, setting use_stardard_msgs and autorepeat_rate causes the crash (as mentioned in https://github.com/naoki-mizuno/ds4_driver/issues/17#issuecomment-851425171) and 2, with your patch this issue is fixed. If you can resolve the two review comments above I'm happy to go ahead and merge this :) Thanks!

geoporus1 commented 3 years ago

@naoki-mizuno the 2 review comments above have been resolved! Happy I could help! Please check if the new updates are ok for you and you can merge this whenever you can! :)

naoki-mizuno commented 3 years ago

Wonderful! Thank you!