Closed geoporus1 closed 3 years ago
Thanks! I'll try out your patch once I get the chance. In the mean time, I added some minor comments.
@naoki-mizuno Thank you for the quick reply! I will address your comments and change the things according to your advice! Hope that you will soon get to try out the patch and we can merge it! Best of luck to you and hope to hear from you soon! :)
I was able to confirm that 1, setting use_stardard_msgs
and autorepeat_rate
causes the crash (as mentioned in https://github.com/naoki-mizuno/ds4_driver/issues/17#issuecomment-851425171) and 2, with your patch this issue is fixed. If you can resolve the two review comments above I'm happy to go ahead and merge this :) Thanks!
@naoki-mizuno the 2 review comments above have been resolved! Happy I could help! Please check if the new updates are ok for you and you can merge this whenever you can! :)
Wonderful! Thank you!
Addresses #17:
controller_ros.py
to match the latestrclpy
documentation. Now the node doesn't crash anymore with wrong import when settinguse_standard_msgs
toTrue
andautorepeat_rate
to something different than 0./dev
folder into the container as this is a quick fix for the controller not disconnecting properly and keeping the previousHIDRAW
file locked. This would lead to the creation of a newHIDRAW
file which cannot be possible set as a--device
before running the container. the bringup also includes an environment variable for mounting the source of the package inside the container for easier development if needed. This can be removed if deemed unnecessary.README
Later edits: