correctly handling the exceptions thrown by the controller disconnecting

naoki-mizuno / ds4_driver

DualShock 4 driver for both ROS1 and ROS2

http://wiki.ros.org/ds4_driver

85 stars 53 forks source link

correctly handling the exceptions thrown by the controller disconnecting #26

Closed geoporus1 closed 2 years ago

geoporus1 commented 2 years ago

these changes are adressing issue #25

sorry for the kinda not-too-clean working tree, this week I have merged the latest changes from the foxy-devel branch on the main repo and continued working on the foxy branch of my fork without rebasing after merge...hopefully this will not be too much of an issue for you...I think you can just squash all the previous commits after accepting the pull request.

naoki-mizuno commented 2 years ago

Thanks for the PR! I haven't been able to run this on my device, but the changes look good to me. I'll go ahead and squash & merge this PR :)