naomijub / edn-rs

[DEPRECATED]: Crate to parse and emit EDN
https://crates.io/crates/edn-rs
MIT License
81 stars 14 forks source link

Add Github Workflows + clippy fixes #102

Closed Grinkers closed 1 year ago

Grinkers commented 1 year ago

Workflows before and after clippy fixes. No functionality changes are intended.

before: https://github.com/Grinkers/edn-rs/actions/runs/5983591578

after: https://github.com/Grinkers/edn-rs/actions/runs/5983672308

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 83.33% and project coverage change: +1.18% :tada:

Comparison is base (e74e564) 69.02% compared to head (18d8045) 70.21%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ========================================== + Coverage 69.02% 70.21% +1.18% ========================================== Files 8 8 Lines 946 940 -6 ========================================== + Hits 653 660 +7 + Misses 293 280 -13 ``` | [Files Changed](https://app.codecov.io/gh/naomijub/edn-rs/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi) | Coverage Δ | | |---|---|---| | [src/edn/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi9tb2QucnM=) | `61.40% <50.00%> (+1.58%)` | :arrow_up: | | [src/serialize/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL3NlcmlhbGl6ZS9tb2QucnM=) | `75.20% <75.00%> (+6.26%)` | :arrow_up: | | [src/edn/utils/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi91dGlscy9tb2QucnM=) | `58.82% <100.00%> (-1.18%)` | :arrow_down: | | [src/json/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2pzb24vbW9kLnJz) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/naomijub/edn-rs/pull/102/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Grinkers commented 1 year ago

btw with pedantic and nursey, there's many pages of output. Most of them seem decent, but some are what I consider false positives like https://rust-lang.github.io/rust-clippy/master/index.html#/must_use_candidate

I'm willing to help maintain and go through everything if #103 can get through. Without clojure.edn/read-string behavior, I can't consider using this crate at this time.

naomijub commented 1 year ago

I think I can try to address the remaining issues this week. Thanks