codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 67.54% and project coverage change: +0.65% :tada:
Comparison is base (
3bcd29d) 70.40% compared to head (693c590) 71.06%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #107 +/- ## ========================================== + Coverage 70.40% 71.06% +0.65% ========================================== Files 8 8 Lines 953 940 -13 ========================================== - Hits 671 668 -3 + Misses 282 272 -10 ``` | [Files Changed](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi) | Coverage Δ | | |---|---|---| | [src/lib.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | | | [src/edn/utils/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi91dGlscy9tb2QucnM=) | `58.82% <22.22%> (ø)` | | | [src/deserialize/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Rlc2VyaWFsaXplL21vZC5ycw==) | `59.20% <50.00%> (+4.38%)` | :arrow_up: | | [src/edn/utils/index.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi91dGlscy9pbmRleC5ycw==) | `20.00% <60.00%> (ø)` | | | [src/edn/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi9tb2QucnM=) | `61.40% <64.28%> (ø)` | | | [src/serialize/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL3NlcmlhbGl6ZS9tb2QucnM=) | `75.20% <83.33%> (ø)` | | | [src/deserialize/parse.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Rlc2VyaWFsaXplL3BhcnNlLnJz) | `92.47% <100.00%> (-0.06%)` | :arrow_down: | | [src/json/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2pzb24vbW9kLnJz) | `100.00% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #104. No functional changes intended.
The following allows are required to pass Nursery lints without breaking pub API compatibility: clippy::module_name_repetitions clippy::fallible_impl_from clippy::needless_pass_by_value
I think all three could be fixed up before a major release. I think these are pretty good TODO markers that can be reevaluated as other issues are resolved (#105 and #106).