search

naomijub / edn-rs

[DEPRECATED]: Crate to parse and emit EDN
https://crates.io/crates/edn-rs
MIT License
81 stars 14 forks source link

64 bit ints instead of pointer size + TryFrom instead of unsafe `as` #113

Closed Grinkers closed 1 year ago

Grinkers commented 1 year ago

Fixes half of #106

codecov-commenter commented 1 year ago

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (6fc058d) 71.39% compared to head (554d715) 71.27%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #113 +/- ## ========================================== - Coverage 71.39% 71.27% -0.13% ========================================== Files 8 8 Lines 944 947 +3 ========================================== + Hits 674 675 +1 - Misses 270 272 +2 ``` | [Files](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi) | Coverage Δ | | |---|---|---| | [src/deserialize/parse.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Rlc2VyaWFsaXplL3BhcnNlLnJz) | `93.28% <100.00%> (ø)` | | | [src/edn/utils/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi91dGlscy9tb2QucnM=) | `66.66% <ø> (+7.84%)` | :arrow_up: | | [src/json/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2pzb24vbW9kLnJz) | `100.00% <ø> (ø)` | | | [src/serialize/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL3NlcmlhbGl6ZS9tb2QucnM=) | `75.20% <ø> (ø)` | | | [src/deserialize/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Rlc2VyaWFsaXplL21vZC5ycw==) | `59.20% <50.00%> (ø)` | | | [src/edn/mod.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi9tb2QucnM=) | `61.13% <47.61%> (-0.27%)` | :arrow_down: | | [src/edn/utils/index.rs](https://app.codecov.io/gh/naomijub/edn-rs/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Julia+Naomi#diff-c3JjL2Vkbi91dGlscy9pbmRleC5ycw==) | `19.78% <23.52%> (-0.22%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

naomijub commented 1 year ago

LGTM, just that one question