Closed Grinkers closed 11 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
36f9a1d
) 71.27% compared to head (2932993
) 71.38%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rebased and pushed, while allowing all tests to pass. I think the implementation is ready for review, but I'm not too happy with how many #[cfg")]
are scattered about. Some amount is unavoidable, but in particular the tests tests are a little ugly. I took a look at some other crates and the common pattern there seems to be something like
// some_tests.rs
mod generic_tests;
#[cfg(feature = "sets")]
mod tests_with_sets;
...
I wanted to take a look at Error handling and a borrow impl (less heap allocations, requiring a walker). I think that might be the time/place to fix/clean this up.
https://github.com/rust-embedded-community/serde-json-core/blob/9deb2b91ea737df79f33f7536587b59ed5f141ee/src/de/mod.rs#L23
for reference for what I sort of had in mind. These can now be added now that we have non_exhaustive
This is a continuation of #110.
This should be after #113. Not worth dealing with merge conflicts, I'll just rebase to keep the history clean.