search

naomijub / edn-rs

[DEPRECATED]: Crate to parse and emit EDN
https://crates.io/crates/edn-rs
MIT License
81 stars 14 forks source link

Bump to rust edition 2021 + best practices. #118

Closed Grinkers closed 10 months ago

Grinkers commented 10 months ago

The async feature has been removed. The async example is now using stable async/futures.

Relevant discussions: https://github.com/naomijub/edn-rs/pull/116 https://github.com/naomijub/edn-rs/issues/117

I'm not sure how many people use this crate, but I think this might be one of the last big breaking changes for standard features. A 0.18.0 release might be a good idea. An added note about an org change (https://github.com/naomijub/edn-rs/issues/109) from 0.19.0 might be a good idea.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fe6b043) 71.38% compared to head (cffc902) 71.53%.

Files Patch % Lines
src/edn/utils/index.rs 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #118 +/- ## ========================================== + Coverage 71.38% 71.53% +0.15% ========================================== Files 8 8 Lines 940 938 -2 ========================================== Hits 671 671 + Misses 269 267 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Grinkers commented 10 months ago

@naomijub hold that release for https://github.com/naomijub/edn-rs/issues/119 hopefully the last breaking change I suggest