search

naomijub / edn-rs

[DEPRECATED]: Crate to parse and emit EDN
https://crates.io/crates/edn-rs
MIT License
81 stars 14 forks source link

`make tests` and `make examples`, combined with `make test`, match CI runners. #124

Closed Grinkers closed 11 months ago

Grinkers commented 11 months ago

For convenience. I keep forgetting what to run.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (831ebf6) 71.28% compared to head (8e6c9bf) 71.28%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ======================================= Coverage 71.28% 71.28% ======================================= Files 8 8 Lines 867 867 ======================================= Hits 618 618 Misses 249 249 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Grinkers commented 11 months ago

@naomijub I can still merge without review

Grinkers commented 11 months ago

Added clippy and fmt too...

Grinkers commented 11 months ago

I figure the Makefile was mostly just for convenience, right? Seeing as how likely any maintainer would also be into Clojure... Anything against babashka tasks?

It's quite convenient. You get a specific error like Error while executing task: test_lib_features, without stuff flying by your screen, while doing bb test. I also just tested it on windows (no msys, WSL, etc. just downloaded bb.exe with standard windows and standand cmd).

I also added an empty .rustfmt.toml. While testing bb tasks on windows, rustfmt was grabbing configs from a parent dir.