search

naomijub / edn-rs

[DEPRECATED]: Crate to parse and emit EDN
https://crates.io/crates/edn-rs
MIT License
81 stars 14 forks source link

`edn-rs/edn-rs` <- `Grinkers/edn-rs` #140

Closed Grinkers closed 7 months ago

Grinkers commented 9 months ago

Issue discussion: https://github.com/edn-rs/edn-rs/issues/139

Grinkers commented 9 months ago

edn-rs now passes roundtrip with clojure (jvm)'s own edn fuzzer https://github.com/Grinkers/edn-rs/pull/3

Grinkers commented 9 months ago

trait Serialize uses reference to self instead of move https://github.com/Grinkers/edn-rs/pull/4

Grinkers commented 9 months ago

Edn::Rational from String to (i64, u64) https://github.com/Grinkers/edn-rs/pull/5

Grinkers commented 8 months ago

EdnError rework with parse rewrite https://github.com/Grinkers/edn-rs/pull/6

Grinkers commented 8 months ago

@naomijub Thanks for starting to look at this. Instead of dealing with this huge draft PR, with some details inside that we may not want to upstream without discussion, I'll start breaking them apart piece by piece and squashing as we go. I mostly put this here for me to track.

We'll have to do it linearly though, I don't want to rebase/isolate 15 separate times; it's work built on top of other work. For example, Rational can be looked at in isolation, but after some other things.

Grinkers commented 8 months ago

Thinking about it, I'll start rebasing against edn-rs/main and deleting comments as we go. Think of this as more of an automatic linear issue tracker. Will delete when there's nothing left!