Improves performance EDN parse by ~80% by using std::str::Chars

naomijub / edn-rs

[DEPRECATED]: Crate to parse and emit EDN

https://crates.io/crates/edn-rs

MIT License

81 stars 14 forks source link

Improves performance EDN parse by ~80% by using std::str::Chars #40

Closed naomijub closed 4 years ago

naomijub commented 4 years ago

Benchmarking parse: Collecting 100 samples in estimated 5.0323 s (439k iteration                                                                              
parse                   time:   [13.570 us 13.606 us 13.641 us]
Performance has improved: 80.560%

We still can improve to 5us

PLEASE REVIEW BUT DONT MERGE IT

evaporei commented 4 years ago

Great PR :clap: :clap: :clap: :clap: :clap: Congrats on making the parsing more reliable!! :blush: I just added a couple notes on some things I think can be influencing performance, can be simplified and or could cause problems :wink: