search

naomiquirke / moodle-mod_cado

Moodle module to generate a course curriculum automatically, compare courses, and enable a course approval workflow within Moodle.
GNU General Public License v3.0
0 stars 0 forks source link

user firstname + lastname instead of fullname() #11

Closed danmarsden closed 4 years ago

danmarsden commented 4 years ago

https://github.com/naomiquirke/moodle-mod_cado/blob/master/classes/get_recipients_form.php#L59

should this be using fullname() ?

this isn't a blocker - just an fyi - feel free to close if you want to keep using firstname/lastname, but fullname takes care of the order of fields, and other internal settings required for different languages / organisations.

naomiquirke commented 4 years ago

OK I've updated, version 1.1