naomiquirke / moodle-mod_cado

Moodle module to generate a course curriculum automatically, compare courses, and enable a course approval workflow within Moodle.
GNU General Public License v3.0
0 stars 0 forks source link

styles.css not specific enough. #7

Closed danmarsden closed 4 years ago

danmarsden commented 4 years ago

in your styles.css you define a number of generic styles that could clash with core moodle code or other locations where simliar names are used.

Moodle helpfully adds a number of classes to the body tag based on the path that you can use, eg if you are have a file in mod/assign you would see the following class added to the body tag path-mod-assign so if you have an item with the class "filething" on the page you would target it like:

.path-mod-assign .filething {
   color: red;
}

Please make sure your css classes in styles.css are specific enough so they cannot clash with other core code.

specific example from your styles.css .p.approvecommentreviewed should probably be more like: .path-mod-cado .p.approvecommentreviewed

naomiquirke commented 4 years ago

Fixed in 1.1