search

naoty / Timepiece

Intuitive date handling in Swift
MIT License
2.63k stars 147 forks source link

`stringIn(dateFormat:)` method for LDML Date representation #88

Closed m3g0byt3 closed 7 years ago

m3g0byt3 commented 7 years ago

Added stringIn(dateFormat:) method in Date+Timepiece extension to create String from Date based on LDML format string (http://www.unicode.org/reports/tr35/tr35-45/tr35-dates.html#Date_Field_Symbol_Table)

naoty commented 7 years ago

Thank you for PR!

I don't want to merge this commit. There are 2 reasons.

  1. dateFormat is easy to be misused. dateStyle and timeStyle is better. You should read https://developer.apple.com/library/content/qa/qa1480/_index.html.
  2. Changes to add a feature and changes to version and CHANGELOG should not be mixed. Also, versioning will be done just before a release, not now.