Not working with react native 0.36

[huyta]

The content height of accordion is always zero

[atlanteh]

a quick fix is to add overflow: 'hidden' after line 111:

        <View
          ref="AccordionContentWrapper"
          style={{
            height: this.getTweeningValue('height'),
            overflow: 'scroll'
          }}
        >

[compojoom]

@atlanteh - thanks. That works for me as well on 0.38.rc.0

[llitfkitfk]

@atlanteh Note: Modify the Source Code (./node_modules/react-native-accordion/src/index.js)

[laxxers]

Modifying the source code doesn't sound like a good fix for this issue. Can someone please raise a PR to fix this?

[atlanteh]

@laxxers please see #42. I've copied the pr locally until this is solved

[iuraya]

The fix proposed by @atlanteh is not compatible with Android

[atlanteh]

Worked for me, both android & iOS.. Maybe your scenario is more complex which might introduce a bug? Can you try it on a very simple example page and see if it works for you.. Also maybe RN latest version broke something? Currently I'm on RN 41and it still seems to work..

[apn-jun]

not working on Android for RN 42

[saumya]

While the quick fix from @atlanteh works on iOS, anyone tried this on Android?! I am on RN-0.36.0.

[compojoom]

I have this working on RN 0.36 with android. @saumya

[saumya]

hi @compojoom thanks for the response. So this works in RN 0.36 on Android, with the quick fix or without the quick fix ? just asking because, if the quick fix is needed, then we have to fix it here for all of us.

[atlanteh]

Now I'm working with pull request #42 (copied locally). Seems to work on all the devices I used. both android and ios. my rn version is 41.2

[compojoom]

this branch has all the fixes I needed to have it work relatively ok on iOS and Android: https://github.com/compojoom/react-native-accordion/tree/compojoom-fixes

I'm currently using it with RN 0.36

[saumya]

Hi @atlanteh does that mean, once merged we will get this issue fixed? If yes, then when can we expect the merge? Thanks

[atlanteh]

Well it works for me.. But I'm not the owner of this repo.. So it's not my decision if to merge it or not

[warent]

Thanks @compojoom !

[eggybot]

I using the duplicate repo of @ercpereda and I found this problem in iOS when i have items in object in map/loop. the solution by @atlanteh works but how can I auto assign height on each loop item?

[ercpereda]

@eggybot I not understand your problem. Can you put some example?