search

naoufal / react-native-payments

Accept Payments with Apple Pay and Android Pay using the Payment Request API.
https://www.npmjs.com/package/react-native-payments
1.59k stars 413 forks source link

Google Pay support? #136

Open rvkuzmik opened 5 years ago

rvkuzmik commented 5 years ago

I see that Android Pay is supported but is Google Pay supported? Android Pay was deprecated and I can only find vague answers on this question. Ref: Issue #46

rvkuzmik commented 5 years ago

Looks like Android Pay and Google Pay are one in the same in these docs... There are a couple vital things missing in the docs for Google Pay implementation... I think I will contribute a pull request to fix the read-me.

wkoutre commented 5 years ago

@rvkuzmik Have you had a chance to write up your findings? I don't see a PR by you :)

ChrisFromCanada commented 5 years ago

Looks like September 30th, 2019 this library is going to start failing with GooglePay because it still uses the Android Pay API.

I have an email from Google that says:

In summary, you’ll be making the following changes to your integration:

  • Replacing loadMaskedWallet and loadFullWallet API calls with loadPaymentData.
  • Creating a PaymentDataRequest object to specify request type and provide necessary information to support a payment.
  • Requesting a gateway token and passing it to your gateway for complete purchase.

The loadMaskedWallet and LoadFullWallet are only used once each so replacing them shouldn't be a big deal...

ChrisFromCanada commented 5 years ago

Also, this tutorial looks useful for understanding exactly what to change. GooglePay Tutorial

ChrisFromCanada commented 5 years ago

Also, this requires apps to be reviewed again by the GooglePay review team, which can take weeks so if this package is going to get an update it needs to be ASAP.

Am I the only one using this package? Hasn't anyone else gotten the emails from Google Pay and wondered what they're going to do?

taylorkline commented 4 years ago

@ChrisFromCanada Have you found the library continue to work past Sep 30?

ChrisFromCanada commented 4 years ago

@taylorkline - I'm not sure if it actually stopped working, but I assume Google kept their word and payments stopped processing on Android for AndroidPay.

I implemented some changes that got it working again using someone else's PR and some additional changes. I have been waiting for the GooglePay review team to respond, letting me know if my integration was successful (it's been 8 days so it should be soon).

Since I managed to retrieve the Stripe token in test mode properly I am pretty sure it's going to go through... I will provide instructions once I get approval.

taylorkline commented 4 years ago

Thanks, @ChrisFromCanada. That would be really helpful.

ChrisFromCanada commented 4 years ago

... Still waiting for the GooglePay review team to review my test integration. It's been 16 days. I think it took 2 - 3 weeks for this stage the first time they approved me (for AndroidPay) so one day soon hopefully!