search

naoufal / react-native-payments

Accept Payments with Apple Pay and Android Pay using the Payment Request API.
https://www.npmjs.com/package/react-native-payments
1.59k stars 413 forks source link

Dont use Carthage in react-native-payments-addon-stripe instead use cocoapods #93

Open darly opened 6 years ago

darly commented 6 years ago

For react-native-payments-addon-stripe it would be best if we you use cocoapods instead of Carthage.

Andreyco commented 6 years ago

Hey there. Got a good news, working on better way to integrate addons into RNP. To be honest, Carthage seems to be better option than Cocoapods. If everything goes well, you will have option to choose one of them.

Andreyco commented 6 years ago

Out of curiosity, have you made an attempt to do tokenization server side? Doing that you, one does not need integrate Braintree/Stripe in RN app... Want to know how RNP consumer approach payments processing

pxue commented 6 years ago

+1 on cocopods, right now we have to manually adds Stripe pods header path to RNP, i'm looking for a packaged solution. maybe add stripe as a pod dependency?

@Andreyco we try to do payment processing on the app side to minimize PCI compliance.

Andreyco commented 6 years ago

Thanks for your feedback. This is interesting insight and I agree. The less you do/store on server, the easier your life gets. Hope to ship better integration of addons in next weeks. Sorry for delays, do what I can.

olivierlesnicki commented 6 years ago

@pxue how do you manually add them?

pxue commented 6 years ago

@olivierlesnicki you can manually link the pod header files like in this commit here

olivierlesnicki commented 6 years ago

Thanks!

pxue commented 6 years ago

@olivierlesnicki circling back, no need for the manual linking. the correct way is to include React subspec in the podfile.

full example uploaded here https://gist.github.com/pxue/052017f38a8f7182cefe1a2e1696912b

rajscet commented 4 years ago

RIP carthage