naoufal / react-native-safari-view

A React Native wrapper for Safari View Controller.
https://www.npmjs.com/package/react-native-safari-view
494 stars 110 forks source link

Does not support Tablets - please fix this #107

Open evanjmg opened 5 years ago

evanjmg commented 5 years ago

https://github.com/naoufal/react-native-safari-view/blob/d828e7911b9588a5c1b3456c7934c587bd0d3c14/SafariViewManager.m#L91 If I run this on a tablet this line makes it not available when it should be available.

koenpunt commented 5 years ago

What kind of fix do you propose?

evanjmg commented 5 years ago

😓 not sure, I just got rejected from Apple since isAvailable didn’t work for their test device. Still having trouble reproducing locally. I removed it and just made sure I only require iOS 10^ for devices - and they accepted it. Perhaps note that it isn’t really necessary?

LinusU commented 5 years ago

React Native only support iOS 9 and newer so shouldn't be a problem to just remove the check? 🤔