search

naoufal / react-native-safari-view

A React Native wrapper for Safari View Controller.
https://www.npmjs.com/package/react-native-safari-view
494 stars 110 forks source link

Adding new functionalities #109

Open gilador opened 5 years ago

gilador commented 5 years ago

added in this commit: hide() unhide() isInit()

koenpunt commented 5 years ago

Thank you for your contribution. What would be a use case for this new functionality?

gilador commented 5 years ago

hey, we are using in-app lock screen. in that case the lock screen would be overran by the webview wheres it should be hidden.

On Sun, 4 Aug 2019 at 11:59, Koen Punt notifications@github.com wrote:

Thank you for your contribution. What would be a use case for this new functionality?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/naoufal/react-native-safari-view/pull/109?email_source=notifications&email_token=AB7MTVKCSHLY7B7YEXV7JR3QC2K7NA5CNFSM4IIKRCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3P5ORQ#issuecomment-517986118, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7MTVLB2X72EAJAYCCAYXTQC2K7NANCNFSM4IIKRCTA .

-- גילעד אור,Gilad or

koenpunt commented 4 years ago

I don't feel much for adding the functionality of hiding the view, since it's a too specific use case, and some would even call it a hack.

And for the isInit method, wouldn't it be more efficient to keep track of that in the JS code of where you're consuming this library?