search

naoufal / react-native-safari-view

A React Native wrapper for Safari View Controller.
https://www.npmjs.com/package/react-native-safari-view
494 stars 110 forks source link

Implement show and dismiss as promises, add completion events #34

Closed robhogan closed 8 years ago

robhogan commented 8 years ago

This takes advantage of the completion handlers on the native side to expose show and dismiss as promises which resolve when the animation is complete. Useful for knowing when it's safe to navigate (for example) within the RN app without clashing with the native view animation.

robhogan commented 8 years ago

Sorry, I've just realised this breaks handling of the 'Done' button - back later!

naoufal commented 8 years ago

No problem. I'm on holiday until next week, so no rush. 😉 On Thu, Aug 25, 2016 at 8:46 PM Rob Hogan notifications@github.com wrote:

Closed #34 https://github.com/naoufal/react-native-safari-view/pull/34.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/naoufal/react-native-safari-view/pull/34#event-767370810, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjWsFTZzjl7U1XUNsm9vT9IjG6ZMJaCks5qjY6YgaJpZM4JsKGu .