search

naoufal / react-native-safari-view

A React Native wrapper for Safari View Controller.
https://www.npmjs.com/package/react-native-safari-view
494 stars 110 forks source link

Add index.js #38

Closed ptmt closed 8 years ago

ptmt commented 8 years ago

It seems that .ios and .android suffixes confuse some JavaScript infrastructure tools like Jest or ESLint. I looked over a few other modules like (react-native-svg, react-native-vector-icons, react-native-maps, etc.), they have root platform-independent file. Do you use react-native-safari-view with Jest and ESLint? Have you managed to avoid module not found problem?

naoufal commented 8 years ago

@ptmt I haven't. Those modules all support Android as well. Have you found any examples from modules that are iOS or Android only?

ptmt commented 8 years ago

Actually, no I have not. But have the similar issue with react-native-linear-gradient. Am I missing something or nobody haven't use the latest Jest with these modules yet, I don't know. Will investigate further.

naoufal commented 8 years ago

@ptmt Sorry about the delay! Merging this in and publishing to npm shortly 👍

naoufal commented 8 years ago

@ptmt just published as react-native-safari-view@1.2.0