search

naoufal / react-native-safari-view

A React Native wrapper for Safari View Controller.
https://www.npmjs.com/package/react-native-safari-view
494 stars 110 forks source link

react-native >= 0.40.0 (December 2016) compatibility #47

Closed 1st8 closed 7 years ago

1st8 commented 7 years ago

See first item under breaking changes: https://github.com/facebook/react-native/releases/tag/v0.40.0

You probably want to bump the major version when merging this, as it is not backwards compatible.

aforty commented 7 years ago

Can this be merged and pushed out ASAP? The major version should bump since this is incompatible with <= 0.39.

naoufal commented 7 years ago

Thanks for the update @1st8. Could you update the example to use 0.40 as well. Once that's done I'll merge this in and release to npm.

1st8 commented 7 years ago

It's done @naoufal I also added the generated yarn.lock in the example, hope that's ok.

naoufal commented 7 years ago

Published on npm under 2.0.0 🚀

Thanks for the PR @1st8! 👋