Closed koenpunt closed 7 years ago
To not break the public API I've mapped the add/removeEventListener to NativeEventEmitter's addListener, instead of returning the subscription; this is a common pattern that can be found also in the React Native core (e.g.: https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Network/NetInfo.js#L210)
add/removeEventListener
NativeEventEmitter
addListener
My previous comment was not completely valid; NativeEventEmitter also implements a removeListener method, so no need to keep track of the listeners ourselves. Still unclear why they use that pattern in the NetInfo module tho..
removeListener
NetInfo
To not break the public API I've mapped theadd/removeEventListenertoNativeEventEmitter'saddListener, instead of returning the subscription; this is a common pattern that can be found also in the React Native core (e.g.: https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Network/NetInfo.js#L210)My previous comment was not completely valid; NativeEventEmitter also implements a
removeListenermethod, so no need to keep track of the listeners ourselves. Still unclear why they use that pattern in theNetInfomodule tho..