search

naoufal / react-native-safari-view

A React Native wrapper for Safari View Controller.
https://www.npmjs.com/package/react-native-safari-view
494 stars 110 forks source link

Not working on RN 0.51.0: Module cannot be null #81

Closed mvanroon closed 6 years ago

mvanroon commented 6 years ago

I've managed to use RNSV on older versions of RN, but not on 0.51.0

Looking at the stacktrace, it seems like SafariViewManager cannot be imported (probably because it hasn't been installed correctly?).

Could it be related to this issue? https://github.com/skycocker/react-native-sfsafariviewcontroller/issues/8

I'm on react 16.0.0, react-native 0.51.0 and RNSV 2.1.0.

schermafbeelding 2017-12-06 om 14 40 56

Update: just upgraded the example from this repo to 0.51.0 without any problems. Still getting the error on my own project though. Any help would be much appreciated.

koenpunt commented 6 years ago

This might have to do with the new linking with CocoaPods support. Do you by any change have a Podfile in your project?

Nb. I haven’t tried 0.51 myself anywhere yet.

mvanroon commented 6 years ago

Thanks for your help Koen.

I've tried renaming the Podfile prior to link-ing react-native-safari-view (and thereby forcing RN to link the old-fashioned way), and this fixed the problem. Thanks again!

Made a new issue for this: https://github.com/naoufal/react-native-safari-view/issues/82