search

naoufal / react-native-speech

A text-to-speech library for React Native.
https://www.npmjs.com/package/react-native-speech
304 stars 53 forks source link

Remove unused invariant, properly use NativeModules #10

Closed bsudekum closed 8 years ago

bsudekum commented 8 years ago

From the looks of it, invariant is not used in this repo.

Also, there is an error with the way NativeModules is loaded. Without this change, I'm seeing the error:

2015-12-05 22:07:56.554 [error][tid:main] Unable to resolve module NativeModules from /my/pathnode_modules/react-native-speech/SpeechSynthesizer.ios.js: Invalid directory /Users/node_modules/NativeModules
joshbuchea commented 8 years ago

This commit fixes the issues @nicholasalanbrown and I were experiencing with 0.14.2. Thanks @bsudekum !

tannewt commented 8 years ago

Fixes NativeModules for me on 0.16 too.

christopherdro commented 8 years ago

@naoufal Working for me as well. Anyway we can get this merged in? Thanks!

naoufal commented 8 years ago

Sorry for the delay everyone, I've been super swamped. Merging now. Thanks for your patience.

@tannewt @christopherdro @joshbuchea @bsudekum

naoufal commented 8 years ago

Published to npm :rocket:

YonasBerhe commented 8 years ago

Nice!