Solve issues of interrupting voice in process

naoufal / react-native-speech

A text-to-speech library for React Native.

https://www.npmjs.com/package/react-native-speech

304 stars 52 forks source link

Solve issues of interrupting voice in process #18

Open paalex opened 7 years ago

paalex commented 7 years ago

if voice is in process, a new call would queue the voice requests
to stop the voice, .stop() can be used as usual
solved a bug with boolean callbacks not crossing the bridge to react-native. @[[NSNull null], @true] instead of @[@true] (which produces an unhandled promise.

tarkanlar commented 7 years ago

I am getting this error node_modules/react-native-speech/SpeechSynthesizer.m:45:5: Use of undeclared identifier 'utterance'

paalex commented 7 years ago

Sorry, fixed it now

paalex commented 7 years ago

Hey @tarkanlar , Can you check the latest commit? It's working now.

tarkanlar commented 7 years ago

Hey @paalex thanks, I just tried. I am getting this error

paalex commented 7 years ago

Hey @tarkanlar , I changed the error to Info only ( will show only in console log). Also added control over time intervals before\after the utterance and control over pitch and volume. Bonus - event emitter for didFinishSpeechUtterance event.

best

tarkanlar commented 7 years ago

Works good Thanks @paalex