search

naoufal / react-native-speech

A text-to-speech library for React Native.
https://www.npmjs.com/package/react-native-speech
304 stars 52 forks source link

Pass through speech rate. #4

Closed tannewt closed 8 years ago

tannewt commented 8 years ago

Pass through speech rate or use the default.

Closes #2

ts-ign0re commented 8 years ago

Hi, could you update the documentation? Thanks!

naoufal commented 8 years ago

@tannewt This change looks good! I just have a question around how the fix handles no utterance rate being passed.

Once that's cleared up and the docs are updated, we should be good merge this.

ghost commented 8 years ago

Just add a default rate at the top

joshbuchea commented 8 years ago

Is the plan still to merge this?

naoufal commented 8 years ago

@joshbuchea Yep, still waiting on @tannewt to update the documentation.

Once that's cleared up and the docs are updated, we should be good merge this.

tannewt commented 8 years ago

Sorry all. I had forgotten about this. :-) I added docs and responded to the question about the default. @naoufal let me know if you have more feedback.

naoufal commented 8 years ago

@tannewt :rocket: LGTM, thanks for your contribution!

naoufal commented 8 years ago

@nashpro @joshbuchea @tannewt Merged and published to npm. https://www.npmjs.com/package/react-native-speech Thanks for the help all.

tannewt commented 8 years ago

Awesome! No problem. On Wed, Nov 18, 2015 at 5:24 AM Naoufal Kadhom notifications@github.com wrote:

@nashpro https://github.com/nashpro @joshbuchea https://github.com/joshbuchea @tannewt https://github.com/tannewt Merged and published on npm. https://www.npmjs.com/package/react-native-speech Thanks for the help all.

— Reply to this email directly or view it on GitHub https://github.com/naoufal/react-native-speech/pull/4#issuecomment-157711899 .

joshbuchea commented 8 years ago

Awesome! Thank you for your efforts gentlemen.