search

naoufal / react-native-touch-id

React Native authentication with the native Touch ID popup.
https://www.npmjs.com/package/react-native-touch-id
1.47k stars 477 forks source link

Support Passcode Fallback along with Fingerprint #216

Open pawankhadpe opened 5 years ago

pawankhadpe commented 5 years ago

Please review the changes and let me know if any changes needed.

vdino96 commented 5 years ago

Hello,

can you review this merge request please. It is necessary for my current project to have a fallback if the fingerprint/face is not recognized :D

aarknvir commented 5 years ago

Hello,

What about merging this? I also need it for a work project ..

@pawankhadpe I may use your fork for this, would you mind explain me how to use the fallback?

Thanks!

divyanshunegi commented 5 years ago

Why is this merge request pending for so long? please merge it if everything is working fine ? I am currently using the forked version by @pawankhadpe and its working as expected

fubar commented 4 years ago

@naoufal @zibs this is absolutely critical functionality. The library is incomplete without it. It's a small change. Please review. Thanks.

fubar commented 4 years ago

@naoufal @zibs I'll start sending reminders until we get someone's attention :p

vdino96 commented 4 years ago

Because I couldn't wait for merge, I simply replaced this with LocalAuthentication from expo and it works. Maybe try that 😄

fubar commented 4 years ago

I've tried to avoid expo because of its extensive dependencies - but it quite likely is the safer bet if this library isn't maintained anymore.

zibs commented 4 years ago

I highly recommend using Expo's LocalAuthentication since it is now available through their unimodules.

I don't have much time for maintaining this library right now, but would like to get into it better shape when I have time again, although I imagine even still the API would be nearly identical to theirs.

Thanks for the PR. I'll try to review it and merge + release it when I have the chance.

fubar commented 4 years ago

Thanks @zibs!

chirag64 commented 4 years ago

Any ETA on this, @zibs?

I understand you've other priorities as of now and may not get time to do this any time soon, but I'm debating on whether I should wait for this PR to be merged or spend time to switch to expo's unimodules. Would prefer the former if possible 😅

siliconavengers commented 4 years ago

@aarknvir just passcodeFallback: true and it will work

@pawankhadpe thanks for your PR. Im using your repo :)

@zibs if you have the time, please have look this PR. Not everybody want to use Expo

KristineTrona commented 3 years ago

When will this be merged? This would be a great addition to the library.