[Android]: isSupported method always returns true on android.

naoufal / react-native-touch-id

React Native authentication with the native Touch ID popup.

https://www.npmjs.com/package/react-native-touch-id

1.47k stars 477 forks source link

[Android]: isSupported method always returns true on android. #218

Open sauravkumar-tudip opened 5 years ago

sauravkumar-tudip commented 5 years ago

Hi,

isSupported method always returns true on the android.

is react-native-touch-id supports faceid on the Android platform?

react-native version: 0.57.7 react-native-touch-id: 4.4.1

Please let me know any package that supports faceid on android also if this package doesn't

MayoudP commented 5 years ago

I have the same error, was just about to create a new issue until a saw this one 👍 :/

BenWildeman commented 5 years ago

@sauravkumar-tudip do you mean that it's returning true for devices that aren't supported/don't have fingerprint enabled, or that it simply returns true instead of the biometry type?

returns true for unsupported/disabled fingerprint devices - might be a bug (can't replicate it myself with devices I have with and without a fingerprint sensor)
returns true instead of the biometric type - this is currently the correct behaviour. There's a PR to change this to be Fingerprint on Android #217

sauravkumar-tudip commented 5 years ago

@BenWildeman it simply returns true instead of the biometry type.

BenWildeman commented 5 years ago

@sauravkumar-tudip thanks for clarifying. was checking because if it was the former, this would be consistent with the bug mentioned in #220 😃