search

napalm-automation-community / napalm-dellos10

NAPALM Driver for Dell EMC OS10 Enterprise
http://dellos10-napalm.readthedocs.io/en/latest/
Apache License 2.0
10 stars 11 forks source link

Implement load_replace_candidate() #40

Open kace opened 2 years ago

kace commented 2 years ago

This method isn't supported according to the readme, but in practice the function call seems to work if we define a dest_file. It's a one line change other than adding tests (not sure if tests are done for anything besides getters?).

Same thing as for #39 I'm trying to push my local fixes upstream.

housepbass commented 2 years ago

I would be very happy to have this functionality. Any status updates on progress?

kace commented 2 years ago

Ah. I've totally forgotten about this. I'll see if I can make time this weekend for it.

housepbass commented 2 years ago

Hey Kace, have you had a chance to work on this? I’m about to do a huge OS10 rollout and this would be supremely helpful.

housepbass commented 2 years ago

What's the one-line change that implements this function? Also, it looks like the operation isn't defined. I have a suspicion this may not be possible as dellos10 doesn't have 'replace candidate' functionality. Is that correct? 

    if self.config_replace:
        # Replace operation
        raise NotImplementedError("Configuration not supported")
    else: