napalm-automation-community / napalm-dellos10

NAPALM Driver for Dell EMC OS10 Enterprise
http://dellos10-napalm.readthedocs.io/en/latest/
Apache License 2.0
10 stars 11 forks source link

get_facts() responds with a 'serial_number' empty value #6

Closed lboue closed 6 years ago

lboue commented 6 years ago

Hello,

I am using napalm-dellos10 plugin to retreive from a S5148F-ON switch. I seems that get_facts() responds with a 'serial_number' empty value as you can see. So I am not able to inventory my equipment.

python napalm-dellos10-get_interfaces.py

{   'fqdn': u'N/A',
    'hostname': u'switch',
    'interface_list': [   u'ethernet1/1/1',
                          u'ethernet1/1/2',
                          ...
                          u'ethernet1/1/53',
                          u'ethernet1/1/54'],
    'model': u'S5148F-ON',
    'os_version': u'10.3.2E(R2)',
    'serial_number': u'N/A',
    'uptime': 246967,
    'uptime': 246967,
    'vendor': u'Dell'
}

Code I notice that serial_number variable remains initialized at UNKNOWN in the code dellos10.py#L487.

model, serial_number, fqdn, os_version, hostname = (self.UNKNOWN,) * 5

Could you implement it and return the service-tag value?

XLM inventory Here is what I get from the XLM inventory:

switch# show inventory | display-xml 
<?xml version="1.0" encoding="UTF-8"?>
<rpc-reply>
  <data>
    <system>
      <node>
        <node-id>1</node-id>
        <node-mac>d8:9e:f3:**:**:**</node-mac>
        <number-of-mac-addresses>256</number-of-mac-addresses>
        <mfg-info>
          <vendor-name>Dell EMC</vendor-name>
          <product-name>S5148F-ON</product-name>
          <hw-version>A00</hw-version>
          <platform-name>x86_64-dellemc_s5100_c2538-r0</platform-name>
          <ppid>CN00Y2VTCE*********</ppid>
          <service-tag>AB1234AB</service-tag>
          <service-code>123 456 789 0</service-code>
        </mfg-info>
        ...
      </node>
    </system>
  </data>
</rpc-reply>

Regards, Ludovic

lboue commented 6 years ago

Refer to PR #11